----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42031/#review122094 -----------------------------------------------------------
My concern with this is how agent-side scripts perform replacments of `_HOST` in Kerberos-related operations. From the sample I looked at, the scripts seem to take the hostame value from the command JSON file (`config['hostname']`). This will be ok if all replacements of `_HOST` work like that, but more research needs to be done to make sure nothing gets broken. The sample of example I looked at were in lifecycle scripts. There are some replacments in alert check scripts that need to be reviewed as well - espically since (I beleive) they are not invoked by way of heartbeat messages. - Robert Levas On Jan. 7, 2016, 3:17 p.m., Greg Hill wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42031/ > ----------------------------------------------------------- > > (Updated Jan. 7, 2016, 3:17 p.m.) > > > Review request for Ambari. > > > Bugs: AMBARI-12915 > https://issues.apache.org/jira/browse/AMBARI-12915 > > > Repository: ambari > > > Description > ------- > > Adds an option to the agent config file to specify the hostname instead of > relying on the system hostname. > > > Diffs > ----- > > ambari-agent/src/main/python/ambari_agent/hostname.py 9cb75d6 > ambari-agent/src/test/python/ambari_agent/TestHostname.py 3cf6b17 > > Diff: https://reviews.apache.org/r/42031/diff/ > > > Testing > ------- > > Added unit tests to confirm desired behavior. > > > Thanks, > > Greg Hill > >
