----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42031/#review122097 -----------------------------------------------------------
Thinking more about this, the Hadoop services as well as some other services, like Oozie, internally perform the `_HOST` replacment with the local host's hostname. This mechanism is not getting the hostname value from the ambari-agent config or ambari-server command files.. I assume uses something that generates a hostname value like `hostname -f`. With this in mind, it seems like _faking_ a hostname in the suggested mannor is a bad idea. - Robert Levas On Jan. 7, 2016, 3:17 p.m., Greg Hill wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42031/ > ----------------------------------------------------------- > > (Updated Jan. 7, 2016, 3:17 p.m.) > > > Review request for Ambari. > > > Bugs: AMBARI-12915 > https://issues.apache.org/jira/browse/AMBARI-12915 > > > Repository: ambari > > > Description > ------- > > Adds an option to the agent config file to specify the hostname instead of > relying on the system hostname. > > > Diffs > ----- > > ambari-agent/src/main/python/ambari_agent/hostname.py 9cb75d6 > ambari-agent/src/test/python/ambari_agent/TestHostname.py 3cf6b17 > > Diff: https://reviews.apache.org/r/42031/diff/ > > > Testing > ------- > > Added unit tests to confirm desired behavior. > > > Thanks, > > Greg Hill > >
