timyuer commented on PR #3757:
URL: https://github.com/apache/ambari/pull/3757#issuecomment-1958986006

   > @MacChen01 @brahmareddybattula
   > 
   > This PR is somewhat disruptive as it changes a lot of content. 
Essentially, the limitation of Ambari's support for multiple operating systems 
is just to ensure the use of the correct package management tool during 
installation. Therefore, after upgrading to Python 3, supporting different 
operating systems becomes easy. It only requires modifying the OS check logic 
to categorize operating systems based on the package manager. For instance, 
operating systems like Red Hat 7, 8, 9, and openEuler would return 'redhat', 
thus uniformly using YUM as the package manager. On the other hand, those using 
APT would be classified as 'ubuntu'. Our production environment has already 
adopted this new approach, making support for new operating systems extremely 
convenient, requiring changes to just one file, oscheck.py. Adding support for 
new operating systems in the future will become very easy. Therefore, I am 
still considering whether to close this PR and discuss on the mailing list 
whether we
  need to change so much code to add a new operating system or if there is a 
simpler way to extend support for other operating systems.
   > 
   > As shown in the following image: support for many operating systems has 
been added by merely changing this code. 
![image](https://private-user-images.githubusercontent.com/18082602/305687410-42074a2d-0f20-4797-93ae-33fcb25ba416.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MDg1OTI0NTAsIm5iZiI6MTcwODU5MjE1MCwicGF0aCI6Ii8xODA4MjYwMi8zMDU2ODc0MTAtNDIwNzRhMmQtMGYyMC00Nzk3LTkzYWUtMzNmY2IyNWJhNDE2LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDAyMjIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwMjIyVDA4NTU1MFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTUxNmExOWYxNGIyNDRjOTdjYjljNTlkMTFmOTlmMTYzMDAwNjUyZjgzZmZkNmM2ZmZmYjU5MGYxNjE1ZjBlMmYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.gXlu-vmpYrYLoZVJbV-zWGz7r-AVxDYDGhHLZjn-n-Q)
   
   @JiaLiangC 
   This is a good idea, but this approach is not very standardized. Do you 
think we may need to consider restructuring the structure of ambari? Welcome to 
open the discussion.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org
For additional commands, e-mail: dev-h...@ambari.apache.org

Reply via email to