wenwj0 commented on PR #3757: URL: https://github.com/apache/ambari/pull/3757#issuecomment-1962918716
> @MacChen01 @brahmareddybattula > > This PR is somewhat disruptive as it changes a lot of content. Essentially, the limitation of Ambari's support for multiple operating systems is just to ensure the use of the correct package management tool during installation. Therefore, after upgrading to Python 3, supporting different operating systems becomes easy. It only requires modifying the OS check logic to categorize operating systems based on the package manager. For instance, operating systems like Red Hat 7, 8, 9, and openEuler would return 'redhat', thus uniformly using YUM as the package manager. On the other hand, those using APT would be classified as 'ubuntu'. Our production environment has already adopted this new approach, making support for new operating systems extremely convenient, requiring changes to just one file, oscheck.py. Adding support for new operating systems in the future will become very easy. Therefore, I am still considering whether to close this PR and discuss on the mailing list whether we need to change so much code to add a new operating system or if there is a simpler way to extend support for other operating systems. > > As shown in the following image: support for many operating systems has been added by merely changing this code.  +1 for this idea. Many operating systems now use YUM as the package manager. If these OS can be grouped into one category, it will be much simpler to add similar operating systems in the future. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For additional commands, e-mail: dev-h...@ambari.apache.org