Hi Xuanwo, Jean-Baptiste, and all,

Thank you both very much for reviewing RC10 and for the detailed,
actionable findings.
All of the problems you raised are valid, and we are grateful for the time
you spent on the review.

For the record, the two problems and their fixes:

   1.

   macOS AppleDouble (.**) entries in the source tarball (found by Xuanwo,
   binding -1). The release machine's rsync/tar serialized extended attributes
   as AppleDouble sidecar files — 3,119 entries in total — and Checkstyle then
   treated .**.java files as Java sources on Linux, which made the source
   package unbuildable.

   Fixed in https://github.com/apache/amoro/pull/4390 (tracking issue:
   https://github.com/apache/amoro/issues/4387): the source-release script
   now disables AppleDouble generation (COPYFILE_DISABLE=1), excludes ._* /
   .DS_Store in both the staging copy and the tar step, builds in a per-run
   isolated temporary directory that is always cleaned up, and — most
   importantly — fails the packaging if the produced archive still contains
   any macOS metadata entry, so this class of pollution can never reach a
   vote again.
   2.

   Incomplete LICENSE (found by Xuanwo and Jean-Baptiste), including
the missing
   ICU attribution for a class derived from ICU4J.

   Fixed in https://github.com/apache/amoro/pull/4389 (tracking issue:
   https://github.com/apache/amoro/issues/4388): LICENSE now carries the
   upstream IBM (1996-2016) and Unicode (2016 and later) copyright notices
   together with the verbatim ICU license text for ByteArrayWrapper.java,
   and lists the remaining Spark/Flink-derived files; LICENSE-binary adds
   the missing CDDL entries (javax.transaction jta 1.1, jaxb-api 2.2.2) and
   moves javassist to the Apache License 2.0 section per its tri-license.

Both fixes are merged into master and backported to the 0.9.x release
branch.

Given the binding -1, we are cancelling this vote. We will cut RC11 from the
updated 0.9.x branch, which carries all of the fixes above, and run the
PPMC vote on [email protected] first. We will then bring the new RC back
to this list for the IPMC vote — hopefully with a boring, clean tarball
this time.

Thanks again for helping us get this release right.

Best regards, ConradJam (czy006)

Jean-Baptiste Onofré <[email protected]> 于2026年9月21日周一 23:22写道:

> 0 (binding)
>
> I suggest to cleanup/fix LICENSE files.
>
> I checked:
> - source distribution
> -- incubating is in the name/version
> -- checksum and signature are correct
> -- DISCLAIMER is present
> -- LICENSE is not complete:
> --- amoro-format-mixed/.../v3.4/.../SparkInternalRowWrapper.java is missing
> in LICENSE (v3.3 and v3.5 are present)
> --- amoro-format-mixed/.../flink/util/ThreadLocalCache.java is missing in
> LICENSE (copied from flink)
> --- some sources copied from Spark
> (MixedFormatParserUtils.scala, MixedFormatSqlExtensionsParser.scala) are
> not listed in LICENSE
> --- amoro-format-mixed/.../flink/lookup/ByteArrayWrapper.java is coming
> from flink, itself mentioning "copied from
> com.ibm.icu.util.ByteArrayWrapper" (ICU4J, licensed under the Unicde/ICU
> License, not Apache license). It should be clearly documented in LICENSE
> -- NOTICE is correct
> -- No compiled/binary files in the source distribution
> -- ASF header is present in all expected files
> - binary distribution
> -- incubating is in the name/version
> -- checksum and signature are correct
> -- DISCLAIMER is present
> -- LICENSE is missing some CDDL dependencies (bundles in the binary
> distribution): activation-1.1.1.jar, jaxb-api-2.2.2.jar,
> javax.annotation-api-1.3.2.jar, javax.servlet-api-3.1.0.jar,
> javax.json-1.0.4.jar, jta-1.1.jar.
> Also javassist is documented as BSD, but it's actually Apache license (tri
> license MPL/LGPL/ALv2)
> -- NOTICE is good (with the LICENSE)
> -- NB: it's a bit weird to have both LICENSE/LICENSE-binary and
> NOTICE/NOTICE-binary
> -- ASF header is present in all expected files
>
> Regards
> JB
>
> On Mon, Sep 21, 2026 at 8:31 AM ConradJam <[email protected]> wrote:
>
> > Hello Incubator PMC,
> >
> > The Apache Amoro community has voted and approved the release of Apache
> > Amoro (incubating) 0.9.0-incubating RC10.
> > We now kindly request the IPMC members review and vote for this release.
> >
> > Apache Amoro (incubating) is a Lakehouse management system built on open
> > data lake formats.
> >
> > Amoro community vote thread:
> > https://lists.apache.org/thread/fc8qryy5rwsrqqglhrzogmctkrjz4v2n
> >
> > Vote result thread:
> > https://lists.apache.org/thread/c0zlx8dlxn3yhvdxcjly7t6mopbmxz26
> >
> > The official Apache source release to be deployed to dist.apache.org:
> >
> >
> https://dist.apache.org/repos/dist/dev/incubator/amoro/0.9.0-incubating-RC10/
> >
> > This source release has been signed with a PGP available here (Apache ID:
> > czy006):
> > https://downloads.apache.org/incubator/amoro/KEYS
> >
> > All artifacts to be deployed to the Maven Central Repository:
> > https://repository.apache.org/content/repositories/orgapacheamoro-1087
> >
> > Git branch for the release:
> > https://github.com/apache/amoro/tree/v0.9.0-rc10
> >
> > Note on the release history: this is the tenth RC of the 0.9.0 cycle.
> > The earlier candidates were retired as community review worked as
> > intended — they resolved a fatal bug found by a binding -1 (#4223),
> > a missing source tarball caught during a vote, packaging issues found
> > by pre-vote checks (incomplete version bumps, stale Helm chart
> > appVersion), and an Iceberg V3 data compatibility issue found before
> > the vote (#4375, fixed by #4376 in this RC); several votes also
> > stalled without quorum and were re-issued. Each candidate carried
> > forward all prior findings, and RC10 passed the community vote with
> > four verified +1s (3 binding).
> >
> > Please download, verify, and test.
> >
> > The VOTE will pass after 3 binding approvals.
> >
> > [ ] +1 approve
> > [ ] +0 no opinion
> > [ ] -1 disapprove with the reason
> >
> > To learn more about Apache Amoro, please see https://amoro.apache.org/
> >
> > Checklist for reference:
> >
> > [ ] Download links are valid.
> > [ ] Checksums and signatures.
> > [ ] LICENSE/NOTICE files exist
> > [ ] No unexpected binary files
> > [ ] All source files have ASF headers
> > [ ] Can compile from source
> >
> > Thanks
> >
>

Reply via email to