+1
Checked all aspects mentioned atTesting a source release for
incubator-annotator
<https://github.com/apache/incubator-annotator/wiki/Testing-a-Source-Release>
on Ubuntu 18,04
All OK except
- signature verification warning
- make check, all passed except the pending cases;
Is resistant to splitting text nodes
- for case: 'simple'
- for case: 'first characters'
- for case: 'last characters'
- for case: 'across elements'
- for case: 'exact element contents'
- for case: 'text inside <head>'
- for case: 'two matches in one node'
- for case: 'matches in multiple nodes'
- for case: 'overlapping matches in one node'
- for case: 'overlapping matches stretching multiple nodes'
- for case: 'no matches'
- for case: 'with prefix'
- for case: 'with suffix'
- for case: 'with prefix and suffix'
- for case: 'with prefix and suffix, two matches'
- for case: 'with prefix, no matches'
- for case: 'with suffix, no matches'
- for case: 'with suffix, no matches due to whitespace'
- for case: 'with empty prefix and suffix'
- for case: 'empty quote'
- for case: 'empty quote, multiple elements'
- for case: 'empty quote, with prefix'
- for case: 'empty quote, with suffix'
- for case: 'empty quote, with prefix and suffix'
- for case: 'empty quote, no matches'
On Fri, Jul 23, 2021 at 1:07 AM Randall Leeds <rand...@apache.org> wrote:
> Based on my results from my last email,
>
> +1
>
> Cheers! Thanks for managing this release, Gerben!
>
> On Thu, Jul 22, 2021, 12:04 Benjamin Young <byo...@bigbluehat.com> wrote:
>
> > Actually...that gpg issue I mentioned was simpler to fix than I'd
> thought.
> >
> > So, here's a legit vote. 🙂
> >
> > +1 based on following all the steps outlined in the Testing a Source
> > Release doc:
> >
> https://github.com/apache/incubator-annotator/wiki/Testing-a-Source-Release
> >
> > Also, the `make check` ran fine (in cmd) on the release--which had failed
> > on a checkout of the tag in git...so I'm off to sort that out
> (hopefully).
> >
> > Great work (again), all!
> > Benjamin
> >
> >
> > --
> >
> > http://bigbluehat.com/
> >
> > http://linkedin.com/in/benjaminyoung
> >
> > ________________________________
> > From: Benjamin Young <byo...@bigbluehat.com>
> > Sent: Thursday, July 22, 2021 11:45 AM
> > To: dev <d...@annotator.incubator.apache.org>; dev@annotator.apache.org <
> > dev@annotator.apache.org>
> > Subject: Re: [VOTE] Release Apache Annotator (incubating) version
> > 0.2.0(-rc.1)
> >
> > Tested the install, build, make trio on the git tag for v0.2.0-rc.1 and
> > all worked well (even on Windows!). Eslint does choke on the line
> endings,
> > but that's not Annotator's fault--and we can debate whether we want to
> > accommodate that line ending difference or not.
> >
> > However, I was not able to test the signature of the .tar.gz due to
> issues
> > with my gpg setup (which I sadly don't currently have time to sort
> out...).
> >
> > +1 for the release (assuming my test of the code is considered
> sufficient)
> >
> > Great work, all!
> >
> > Cheers!
> > Benjamin
> >
> >
> > --
> >
> > http://bigbluehat.com/
> >
> > http://linkedin.com/in/benjaminyoung
> >
> > ________________________________
> > From: Gerben <ger...@treora.com.INVALID>
> > Sent: Wednesday, July 21, 2021 12:06 PM
> > To: dev <d...@annotator.incubator.apache.org>
> > Subject: [VOTE] Release Apache Annotator (incubating) version
> 0.2.0(-rc.1)
> >
> > Hi all,
> >
> > I propose we release Apache Annotator (incubating) 0.2.0.
> >
> > The release artifacts are available here:
> > <
> >
> https://dist.apache.org/repos/dist/dev/incubator/annotator/source/0.2.0/rc.1
> > >
> >
> > PMC committers, please verify the artifacts following the steps described
> > in our wiki, here:
> > <
> >
> https://github.com/apache/incubator-annotator/wiki/Testing-a-Source-Release
> > >
> >
> > Then let know if it works or if you encounter any issues, and vote:
> >
> > +1 - release this package as 0.2.0
> > +0 - no opinion
> > -1 - do not release this package
> >
> > If the vote passes, these artifacts will be released as Apache Annotator
> > (incubating) 0.2.0.
> >
> > Non-committers are also most welcome to check the package and vote
> (albeit
> > non-bindingly), and your feedback would be highly appreciated.
> >
> > The vote will be open for at least 72 hours.
> >
> > Kind regards,
> >
> > — Gerben
> >
> >
>
