On Tuesday 23 September 2003 14:25, [EMAIL PROTECTED] wrote: > Thats the advantage of automated unit tests :-) > > Ok, I refactor the test suite a little bit. > > Because we have a 1.6 version and a head version on cvs. How should > I commit the changes?
On both versions. The easiest is to make the changes on HEAD, make a diff file (before the commit on HEAD), and apply the changes to 1.6, and then commit in both. Peter > > > Jan > > > -----Original Message----- > > From: Stefan Bodewig [mailto:[EMAIL PROTECTED] > > Sent: Tuesday, September 23, 2003 3:24 PM > > To: [EMAIL PROTECTED] > > Subject: Re: concat teardown failing > > > > On Tue, 23 Sep 2003, Jan Materne <[EMAIL PROTECTED]> wrote: > > > I have modified the FileUtils.readFully(Reader rdr, int bufferSize) > > > so that it closes the reader and all works. > > > > I think that would be the wrong place. It may be my old C thinking > > coming from explicit memory managment, but I think that the code that > > aquires a resource should be responsible of releasing it as well. > > > > > Ups - some other tests failed because of the closed reader. So I > > > close the reader in the ConcatFilterTest. > > > > You see 8-) > > > > Stefan > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: [EMAIL PROTECTED] > > For additional commands, e-mail: [EMAIL PROTECTED] --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
