--- Antoine Levy-Lambert <[EMAIL PROTECTED]> wrote: > Hello Xavier, > > the patch is welcome, but I do not see the > attachment ? maybe it > comes from my email reader.
Nor did I. :) -Matt > > Regards > > Antoine > On Sep 20, 2006, at 8:42 AM, Xavier Hanin wrote: > > > Hi Matt and Antoine, > > > > While looking at your patch Antoine I had a look > at the URLResource > > source code, and I think it would need some > improvement about > > connection closing: > > * your patch only takes care of closing the > connection when calling > > getSize(), but I think it should be closed > whenever it is opened. > > * there is another type of URLConnection which > needs to be closed: > > HttpURLConnection. We had problems with non closed > > > HttpURLConnection in first versions of Ivy, and a > user contributed > > a simple patch very similar to the one you have > for closing a > > JarConnection. > > > > Please find attached a patch solving these issues. > Feel free to > > modify whatever you want or keep only a small > part, I don't know > > Antinternals very well, so maybe what I've done is > not very well > > designed. I've tried to compensate with some > comments. > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: > [EMAIL PROTECTED] > For additional commands, e-mail: > [EMAIL PROTECTED] > > __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
