DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUGĀ· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT <http://issues.apache.org/bugzilla/show_bug.cgi?id=40979>. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED ANDĀ· INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=40979 Summary: Use protected instead of private methods in Tasks Product: Ant Version: unspecified Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P2 Component: Core tasks AssignedTo: dev@ant.apache.org ReportedBy: [EMAIL PROTECTED] Methods in Ant tasks should offer their services to subclasses. For example, when the CvsTagDiff executes, it splits its work into: - construct the cvs command line - parse the RDiff (that returns CvsTagEntry[] entries) - write these entries. A sub class that want to do something else than writing the entries may benefit from the above methods being protected instaed of private. I found a similar example in the Get task. There is no problem to copy the code when creating a new Task, but it would be better to inherit from (reuse) the existing one. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]