Github user jaikiran commented on the issue:
https://github.com/apache/ant-ivy/pull/53
Hi Gintas,
Given the amount of commits and the changes involved in this PR, it's a bit
difficult to review it. I think this PR even includes some of the changes that
have already been included in upstream master from one of your other PR.
What I have instead now done is - reviewed individual smaller commits from
this PR which were isolated enough to be easily reviewed/merged.
I have `cherry-pick`ed the following commits from this PR, squashed them in
one commit and merged it upstream:
-
https://github.com/apache/ant-ivy/pull/53/commits/cceb05ebfce3d481a97e46f384afbcd2eca66005
-
https://github.com/apache/ant-ivy/pull/53/commits/cce7276a93e50c7ed608987697ec08d3b0d2f2af
-
https://github.com/apache/ant-ivy/pull/53/commits/381991072529d832fcdfb422d2e99599d037d30e
The merged commit upstream is this one
https://github.com/apache/ant-ivy/commit/d4c3cbccaf05beeb11712294ef4dd0af25d9d0f4
Furthermore, since the same PR keeps getting updated regularly with changes
and new commits, it becomes difficult to keep track of what to review and
what's pending.
For the rest of the commits that I haven't been able to review yet (given
their size and nature), could you please create isolated individual PRs (on
separate personal branches), all rebased against latest master branch? That
will make it a bit more easier to review them.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org
