Github user jaikiran commented on a diff in the pull request:
https://github.com/apache/ant/pull/58#discussion_r166183611
--- Diff: src/main/org/apache/tools/ant/listener/MailLogger.java ---
@@ -102,7 +102,7 @@
private static final String DEFAULT_MIME_TYPE = "text/plain";
/** Buffer in which the message is constructed prior to sending */
- private StringBuffer buffer = new StringBuffer();
+ private StringBuilder buffer = new StringBuilder();
--- End diff --
I'm not too sure this change here, in this class is correct. The
`StringBuffer` is a thread-safe class whereas the `StringBuilder` isn't. Having
said that I haven't checked yet whether MailLogger class is expected to be
thread safe nor have I checked its usage thoroughly.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
