jaikiran commented on issue #89: Added version and mainClass attributes to <jar> task. URL: https://github.com/apache/ant/pull/89#issuecomment-477867207 While you are here, a quick suggestion/question - given that these changes are related to Java modules in general and there probably will be more such enhancements for modules, maybe we should rename the newly added `org.apache.tools.ant.util.jarattr` package to `org.apache.tools.ant.util.modules` instead? I don't have a strong opinion on it, so if you want to use the current package name that you chose, that's fine by me.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
