If the goal of 1.10.12 is to be compilable on Java 17, shouldn't unit tests
for script-related tasks in Ant core be complemented with an assumption
that Rhino, Nashorn or Graal JS is around?

Gintas


On Tue, 5 Oct 2021 at 10:58, Paul King <pa...@asert.com.au> wrote:

> +0 (non-binding)
>
> I checked:
> * LICENSE & NOTICE seem okay
> * HASH & SIG seem okay
> * I ran against the Groovy test suite which has 100+ ant-related tests and
> all continue to pass (using JDK16 and the upcoming Groovy 4)
>
> I was surprised to see binary jars in the src archives under lib/optional.
> I don't know the history, so perhaps it is fine.
>
> Cheers, Paul.
>
>
>
> On Thu, Sep 30, 2021 at 12:58 PM Jaikiran Pai <jaiki...@apache.org> wrote:
>
> > I've created a release candidate for 1.10.12:
> >
> > git tag: ANT_1.10.12_RC1
> >           on commit: cb7f242aa099c069bd75e6ee4d6e50b56fd73b71
> > tarballs: https://dist.apache.org/repos/dist/dev/ant/
> >            revision: 50166
> > Maven artifacts:
> > https://repository.apache.org/content/repositories/orgapacheant-1051/
> > Snapcraft Build
> >            Revision 21 in latest/candidate
> >
> > This release is mainly a bug fix release and the exact changes are noted
> > in
> > https://dist.apache.org/repos/dist/dev/ant/RELEASE-NOTES-1.10.12.html.
> > Of particular interest is the relatively minor bug fix in the javadoc
> > task which is necessary for it to work properly in the recently released
> > Java 17 version.
> >
> > This vote will be open at least for 72 hours and close no earlier than
> > 4th October 2021 03:00 AM UTC (given that it's a weekend in the next
> > couple of days, I decided to extend the voting period till Monday)
> >
> >
> > -Jaikiran
> >
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
> > For additional commands, e-mail: dev-h...@ant.apache.org
> >
> >
>

Reply via email to