On Sat, 6 Jun 2026 at 12:15, Stefan Bodewig <[email protected]> wrote:
On 2026-06-06, Gintautas Grigelionis wrote: > > > I would appreciate it if somebody looks at PR 60 again. > > I've tried, but failed. Sorry. > > I haven't got the slightest idea what the xooki stuff[1] does so am > obviously not qualified to review, I'm afraid. Didn't you say we > wouldn't use xooki anymore? :-) > > Other than that I see hex to named color conversions and replacing some > bitmaps with SVGs - sprinkled with a seemingly unrelated CSS change[2] > and a change to a ruby helper that does something that also doesn't seem > to be related to the PR's title at all (I haven't got any idea what it > does). > > Stefan > > [1] > https://github.com/apache/ant-ivy/pull/60/changes#diff-426bd30a49027fd8e268b40ae0783a4615b11e4ba696aa6ee30e619abcc163b7R31 > > [2] > https://github.com/apache/ant-ivy/pull/60/changes#diff-3d275c368080b9e39b6c2574f429747c13e8e856a9a57c1887bdd00def53aa6fR315 I am sorry to say, but it seems that you did not even try, just blamed it on the "xooki" CSS tag and dismissed it. Ruby helper sets the CSS tags (yes, "xooki" lives there by name only). The rest is a cleanup of CSS and elimination of some bitmap images which should improve performance in modern browsers. Should I provide a writeup in the comment to the PR? Gintas
