> I am sorry to say, but it seems that you did not even try, just blamed it > on the "xooki" CSS tag and dismissed it.
I don't have the slightest clue what it does and it does something to the javascript in a template written for a template engine I'm not familiar with at all. And the PR description gives no justification why it should be there. Right. > Ruby helper sets the CSS tags (yes, "xooki" lives there by name only). It set the id to a different value than before and I don't understand why. > The rest is a cleanup of CSS and elimination of some bitmap images which > should improve performance in modern browsers. It also adds a selector for treeview that hasn't been there before which is not my understanding of cleanup. > Should I provide a writeup in the comment to the PR? Not for me, I'm out. You will find somebody else to review it, I guess. In general for me a PR should say what it does - and why in case this isn't obvious. And not do anythng that it doesn't say it would do. And not do anything like "cleanup" when it wants to do anything other than cleanup as well. That's just me and this is not new and you already knew that. :-) Stefan --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
