HansBrende commented on a change in pull request #151: ANY23-445 Review
spotbugs issues
URL: https://github.com/apache/any23/pull/151#discussion_r335292090
##########
File path: api/src/main/java/org/apache/any23/vocab/HCard.java
##########
@@ -36,10 +36,9 @@ public static HCard getInstance() {
return instance;
}
- public IRI Card = createClass(NS, "Card");
- public IRI Address = createClass(NS, "Address");
- public IRI Geo = createClass(NS, "Geo");
-
+ public IRI card = createClass(NS, "Card");
+ public IRI address = createClass(NS, "Address");
+ public IRI _Geo = createClass(NS, "Geo");
Review comment:
These are breaking changes. We probably don't want to release another major
version for this, so if we want to change the naming, we should probably
deprecate the old ones rather than removing them.
But in any case, how is `_Geo` an improvement over `Geo`? Not sure I agree
with that naming change...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
