HansBrende commented on a change in pull request #151: ANY23-445 Review
spotbugs issues
URL: https://github.com/apache/any23/pull/151#discussion_r335806549
##########
File path: api/src/main/java/org/apache/any23/extractor/ExtractorGroup.java
##########
@@ -78,6 +78,7 @@ public boolean allExtractorsSupportAllContentTypes() {
return true;
}
+ @SuppressWarnings("unlikely-arg-type")
Review comment:
There's actually a bug here, so adding `@SuppressWarnings` kinda defeats the
purpose of the spotbugs plugin. `getSupportedMIMETypes()` returns a list of
`MIMEType`, so checking if it contains a `String` will always return false!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services