lewismc commented on a change in pull request #151: ANY23-445 Review spotbugs
issues
URL: https://github.com/apache/any23/pull/151#discussion_r335541136
##########
File path: api/src/main/java/org/apache/any23/vocab/HCard.java
##########
@@ -36,10 +36,9 @@ public static HCard getInstance() {
return instance;
}
- public IRI Card = createClass(NS, "Card");
- public IRI Address = createClass(NS, "Address");
- public IRI Geo = createClass(NS, "Geo");
-
+ public IRI card = createClass(NS, "Card");
+ public IRI address = createClass(NS, "Address");
+ public IRI _Geo = createClass(NS, "Geo");
Review comment:
> These are breaking changes.
Is changing the variable name breaking? Please clarify, I am no clear.
> we should probably deprecate the old ones rather than removing them.
Yes, that's an option.
> But in any case, how is _Geo an improvement over Geo?
I don't think it necessarily is tbh.
> Not sure I agree with that naming change...
I agree. Let me try and explain what spotsbugs is saying...
**_regarding capitalization_**
> Field names should start with a lower case letter
Names of fields that are not final should be in mixed case with a lowercase
first letter and the first letters of subsequent words capitalized.
Bug kind and pattern: Nm - NM_FIELD_NAMING_CONVENTION
That is all. Should we just disarm this check?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
