lewismc commented on a change in pull request #151: ANY23-445 Review spotbugs
issues
URL: https://github.com/apache/any23/pull/151#discussion_r336088793
##########
File path: api/src/main/java/org/apache/any23/extractor/ExtractorGroup.java
##########
@@ -78,6 +78,7 @@ public boolean allExtractorsSupportAllContentTypes() {
return true;
}
+ @SuppressWarnings("unlikely-arg-type")
Review comment:
I've removed both the `SupressWarnings` javac annotation and thought about
this one again.
I've decided to introduce
`<omitVisitors>FindUnrelatedTypesInGenericContainer</omitVisitors>` which will
omit spotbugs from identifying this issue as a bug. My justification is that,
in this case, because the `ExtractorFactory#getSupportedMIMETypes()` supports
wildcards, and as far as I can see there is currently no way to determine the
full Collection (e.g. `*/*`) of supported `MimeType`'s then we cannot enforce
another check whether an `ExtractorGroup` supports all `MimeType`'s.
What do you think about this assessment?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
