Github user PramodSSImmaneni commented on a diff in the pull request:

    https://github.com/apache/apex-core/pull/350#discussion_r67060191
  
    --- Diff: 
engine/src/main/java/com/datatorrent/stram/engine/StreamingContainer.java ---
    @@ -769,7 +769,11 @@ public void 
processHeartbeatResponse(ContainerHeartbeatResponse rsp)
         }
     
         if (rsp.committedWindowId != lastCommittedWindowId) {
    +
           lastCommittedWindowId = rsp.committedWindowId;
    +
    +      bufferServer.purge(lastCommittedWindowId);
    --- End diff --
    
    Shouldn't this be a request that is sent to bufferserver from the streaming 
container otherwise this introduces a dependency which we didn't rely on before 
that bufferserver is in the same process.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to