Github user PramodSSImmaneni commented on a diff in the pull request:
https://github.com/apache/apex-core/pull/350#discussion_r67063171
--- Diff:
engine/src/main/java/com/datatorrent/stram/engine/StreamingContainer.java ---
@@ -769,7 +769,11 @@ public void
processHeartbeatResponse(ContainerHeartbeatResponse rsp)
}
if (rsp.committedWindowId != lastCommittedWindowId) {
+
lastCommittedWindowId = rsp.committedWindowId;
+
+ bufferServer.purge(lastCommittedWindowId);
--- End diff --
I would think it would be an option in that case too. Do you know if there
was a discussion to dev list to fundamentally change the approach and only do
inline. If it was discussed and this conclusion was reached I think it would be
prudent to wait for that change to get in before merging this one.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
