Github user sandeshh commented on a diff in the pull request:

    https://github.com/apache/apex-core/pull/350#discussion_r68496137
  
    --- Diff: 
engine/src/main/java/com/datatorrent/stram/engine/StreamingContainer.java ---
    @@ -769,7 +769,11 @@ public void 
processHeartbeatResponse(ContainerHeartbeatResponse rsp)
         }
     
         if (rsp.committedWindowId != lastCommittedWindowId) {
    +
           lastCommittedWindowId = rsp.committedWindowId;
    +
    +      bufferServer.purge(lastCommittedWindowId);
    --- End diff --
    
    Wrote a sample application and tested this change by killing the 
containers. There was no issue and the recovery started from the expected 
window id ( committed + 1 ). Still not sure why we have to keep the window data 
of the committed window. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to