Github user sandeshh commented on a diff in the pull request:

    https://github.com/apache/apex-core/pull/350#discussion_r70022763
  
    --- Diff: 
bufferserver/src/main/java/com/datatorrent/bufferserver/server/Server.java ---
    @@ -199,6 +199,13 @@ private void handlePurgeRequest(PurgeRequestTuple 
request, final AbstractLengthP
         }
       }
     
    +  public void purge(long windowId)
    +  {
    +    for (DataList dataList: publisherBuffers.values()) {
    --- End diff --
    
    Purge inside the *Block* is not thread safe, but the Purge inside the 
*DataList* calls the Block purge using Synchronized block. So it should be fine.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to