[
https://issues.apache.org/jira/browse/APEXMALHAR-2156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15394579#comment-15394579
]
ASF GitHub Bot commented on APEXMALHAR-2156:
--------------------------------------------
Github user sanjaypujare commented on a diff in the pull request:
https://github.com/apache/apex-malhar/pull/347#discussion_r72341421
--- Diff: library/src/main/java/com/datatorrent/lib/io/jms/JMSBase.java ---
@@ -76,18 +76,24 @@
private transient Session session;
private transient Destination destination;
+ private ConnectionFactoryBuilder connectionFactoryBuilder;
private String connectionFactoryClass;
private Map<String, String> connectionFactoryProperties =
Maps.newHashMap();
private String ackMode = "CLIENT_ACKNOWLEDGE";
- private String clientId = "TestClient";
- private String subject = "TEST.FOO";
+ private String clientId;
+ private String subject;
--- End diff --
Subject is used only in the topic mode (pub-sub mode) and only with
ActiveMQ since SQS supports only the queue mode. So in the topic mode subject
has to be non-null but that part of the code hasn't changed and is not even
being tested (previous JMSInputOperator only had tests for the queue mode). The
only thing I did was to remove the hard-coding of subject to "TEST.FOO". I'll
create a JIRA to do the constraint check in the topic mode.
> JMS Input operator enhancements
> -------------------------------
>
> Key: APEXMALHAR-2156
> URL: https://issues.apache.org/jira/browse/APEXMALHAR-2156
> Project: Apache Apex Malhar
> Issue Type: Improvement
> Reporter: Sanjay M Pujare
> Assignee: Sanjay M Pujare
> Original Estimate: 672h
> Remaining Estimate: 672h
>
> This is described in
> https://drive.google.com/open?id=1gapzjxTiePP0VwaOrc-FWfw4xNK6bcIuxkNkGKoZAiA
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
