[
https://issues.apache.org/jira/browse/APEXMALHAR-2156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15394601#comment-15394601
]
ASF GitHub Bot commented on APEXMALHAR-2156:
--------------------------------------------
Github user PramodSSImmaneni commented on a diff in the pull request:
https://github.com/apache/apex-malhar/pull/347#discussion_r72343606
--- Diff: library/src/main/java/com/datatorrent/lib/io/jms/JMSBase.java ---
@@ -355,10 +366,13 @@ public void createConnection() throws JMSException
*/
protected ConnectionFactory getConnectionFactory()
{
- logger.debug("class {} properties {}", connectionFactoryClass,
connectionFactoryProperties);
+ logger.debug("connectionFactoryBuilder {} connectionFactoryClass {}
properties {}", "" + connectionFactoryBuilder,
+ connectionFactoryClass, connectionFactoryProperties);
ConnectionFactory cf;
try {
- if (connectionFactoryClass != null) {
+ if (connectionFactoryBuilder != null) {
+ cf = connectionFactoryBuilder.buildConnectionFactory();
+ } else if (connectionFactoryClass != null) {
--- End diff --
Instead of having multiple mechanisms wouldn't it be better to encapsulate
the factory from class instanatiation into a default factory builder?
> JMS Input operator enhancements
> -------------------------------
>
> Key: APEXMALHAR-2156
> URL: https://issues.apache.org/jira/browse/APEXMALHAR-2156
> Project: Apache Apex Malhar
> Issue Type: Improvement
> Reporter: Sanjay M Pujare
> Assignee: Sanjay M Pujare
> Original Estimate: 672h
> Remaining Estimate: 672h
>
> This is described in
> https://drive.google.com/open?id=1gapzjxTiePP0VwaOrc-FWfw4xNK6bcIuxkNkGKoZAiA
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
