I don't see need for the flag either. The output of the command should
be what applications were stopped/shutdown and which one were not (for
On 8/4/17 23:21, Sanjay Pujare wrote:
+1 for best effort. I don't think a flag to offer alternative behavior is
of much value.
On Aug 5, 2017 11:31 AM, "AJAY GUPTA" <ajaygit...@gmail.com> wrote:
It could be useful to have a flag and let user decide the best approach fit
for him. We can have the default behaviour as best-effort with support for
Validate and fail via flag.
On Sat, 5 Aug 2017 at 8:33 AM, Bhupesh Chawda <bhup...@datatorrent.com>
+1 for best effort with warnings.
On Aug 4, 2017 23:46, "Pramod Immaneni" <pra...@datatorrent.com> wrote:
I would prefer "Best effort" with warnings for the ones that are
On Fri, Aug 4, 2017 at 9:42 AM, Florian Schmidt <
I am currently extending the ApexCli so that the `shutdown-app`
supports the both the appId and the appName as an argument (see
During the review of the pull request, the following discussion came
When a user passes multiple appNames / appIds to the shutdown command
(e.g. shutdown-app appA appB appC) and e.g. appB does not exists,
of the two approaches do we want to go:
"Best effort”: Try to shutdown all those apps where we can find an
the provided appName or appId. Print a warning if an app cannot
“Validate and Fail”: Validate that all apps can be found by the
appId / appName. Do not run the command if one of the apps can’t be
This decision would probably influence the behavior of other CLI
in the future as well, so that they all behave in a consistent way.
are your opinions?