Thanks for the review! The duplicate headers in *.java are caused by leading blank lines, which we need to remove to make the automated formatting work. My idea is that we first do those tweaks and then update everything with the final header. See also #69
I'm actually in favor of excluding .txt files from header formatting. Other thoughts on this? On Thu, Sep 24, 2015 at 8:53 AM, Brennon York <[email protected]> wrote: > @tweise <https://github.com/tweise> went through all the files and marked > each file below if I saw some sort of issue (whether you already know about > it or not :) ) > > Below are a list of the files I noticed that, after running this, would > have two licenses (i.e. we should reformat rather than add new licenses on > these): > > - Name.java > - VarInt.java > - SingleMetricAggregator.java > - DoubleSumAggregator.java > - LongSumAggregator.java > - AppDataSource.java > - Slider.java > - CompactAnnotationNode.java > - CompactFieldNode.java > - FieldSignatureVisitor.java > > Do we need a License header for a README as well (best I found as guidance > on this is here > <http://www.apache.org/legal/src-headers.html#faq-exceptions>? > > - engine/src/main/resources/webapps/stram/README.txt > - > > engine/src/test/resources/testConfigPackage/testConfigPackageSrc/files/xyz.txt > > Not sure if this one should have the license moved up one line to be below > the <?xml version="1.0" encoding="UTF-8"?> > > - engine/src/test/resources/dt-site.xml > > We don't need a license here I'm assuming as it already has the license > from Apache Hadoop > > - engine/src/test/resources/yarn-site.xml > > — > Reply to this email directly or view it on GitHub > <https://github.com/apache/incubator-apex-core/pull/73#issuecomment-142971005> > . >
