It's the same though I had when I looked at it; I thought consistency across apache projects could be driving it. Is it not true?
-- Chetan On Thu, Sep 24, 2015 at 12:02 PM, York, Brennon <[email protected] > wrote: > I don¹t want to be pedantic here, but, according to Apache, I¹d *only* > keep license headers out of .txt files if they contain "without any degree > of creativity in either its literal elements or its structure². That said, > I¹d, at a minimum, put a license header on every README.md file and review > the rest. More work, but I¹d say its worth it. I only saw one .txt file > (xyz.txt) in the PR that wasn¹t a README.md so might be a quick fix. > > Just my 2c. > > On 9/24/15, 11:41 AM, "Thomas Weise" <[email protected]> wrote: > > >Yes, please see my comments on that pull request. > > > >https://github.com/apache/incubator-apex-core/pull/69 > > > >Can you please remove the changes that add the outdated license header so > >that I can pull it in and rebase this? > > > >On Thu, Sep 24, 2015 at 11:31 AM, Chetan Narsude <[email protected]> > >wrote: > > > >> There is a pending pull request from me which fixes all this from me > >>since > >> yesterday afternoon. > >> > >> -- > >> Chetan > >> > >> > >> On Thu, Sep 24, 2015 at 11:26 AM, Thomas Weise <[email protected]> > >> wrote: > >> > >> > Thanks for the review! > >> > > >> > The duplicate headers in *.java are caused by leading blank lines, > >>which > >> we > >> > need to remove to make the automated formatting work. My idea is that > >>we > >> > first do those tweaks and then update everything with the final > >>header. > >> See > >> > also #69 > >> > > >> > I'm actually in favor of excluding .txt files from header formatting. > >> Other > >> > thoughts on this? > >> > > >> > > >> > > >> > On Thu, Sep 24, 2015 at 8:53 AM, Brennon York > >><[email protected]> > >> > wrote: > >> > > >> > > @tweise <https://github.com/tweise> went through all the files and > >> > marked > >> > > each file below if I saw some sort of issue (whether you already > >>know > >> > about > >> > > it or not :) ) > >> > > > >> > > Below are a list of the files I noticed that, after running this, > >>would > >> > > have two licenses (i.e. we should reformat rather than add new > >>licenses > >> > on > >> > > these): > >> > > > >> > > - Name.java > >> > > - VarInt.java > >> > > - SingleMetricAggregator.java > >> > > - DoubleSumAggregator.java > >> > > - LongSumAggregator.java > >> > > - AppDataSource.java > >> > > - Slider.java > >> > > - CompactAnnotationNode.java > >> > > - CompactFieldNode.java > >> > > - FieldSignatureVisitor.java > >> > > > >> > > Do we need a License header for a README as well (best I found as > >> > guidance > >> > > on this is here > >> > > <http://www.apache.org/legal/src-headers.html#faq-exceptions>? > >> > > > >> > > - engine/src/main/resources/webapps/stram/README.txt > >> > > - > >> > > > >> > > >> > >>engine/src/test/resources/testConfigPackage/testConfigPackageSrc/files/xy > >>z.txt > >> > > > >> > > Not sure if this one should have the license moved up one line to be > >> > below > >> > > the <?xml version="1.0" encoding="UTF-8"?> > >> > > > >> > > - engine/src/test/resources/dt-site.xml > >> > > > >> > > We don't need a license here I'm assuming as it already has the > >>license > >> > > from Apache Hadoop > >> > > > >> > > - engine/src/test/resources/yarn-site.xml > >> > > > >> > > ‹ > >> > > Reply to this email directly or view it on GitHub > >> > > < > >> > > >> > >> > https://github.com/apache/incubator-apex-core/pull/73#issuecomment-142971 > >>005 > >> > > > >> > > . > >> > > > >> > > >> > > ________________________________________________________ > > The information contained in this e-mail is confidential and/or > proprietary to Capital One and/or its affiliates and may only be used > solely in performance of work or services for Capital One. The information > transmitted herewith is intended only for use by the individual or entity > to which it is addressed. If the reader of this message is not the intended > recipient, you are hereby notified that any review, retransmission, > dissemination, distribution, copying or other use of, or taking of any > action in reliance upon this information is strictly prohibited. If you > have received this communication in error, please contact the sender and > delete the material from your computer. > >
