Github user ilooner commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/81#discussion_r40699218
--- Diff:
engine/src/test/java/com/datatorrent/stram/plan/logical/LogicalPlanTest.java ---
@@ -683,7 +686,85 @@ public void testJdkSerializableOperator() throws
Exception {
Assert.assertNotNull("port object null", o1Clone.inport1);
}
- private static class TestStreamCodec implements StreamCodec<Object> {
+ @Test
+ public void testAttributeValuesSerializableCheck() throws
NoSuchFieldException, SecurityException, IllegalArgumentException,
IllegalAccessException
+ {
+ LogicalPlan dag = new LogicalPlan();
+ Attribute<Object> attr = new Attribute<Object>(new
TestAttributeValue(), new Object2String());
+ Field nameField = Attribute.class.getDeclaredField("name");
+ nameField.setAccessible(true);
+ nameField.set(attr, "Test_Attribute");
+ nameField.setAccessible(false);
+
+ assertNotNull(attr);
--- End diff --
Is this assert checking anything important. Couldn't it be removed?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
