Github user ishark commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/81#discussion_r40718327
--- Diff: engine/src/test/resources/testTopology.json ---
@@ -25,7 +25,7 @@
"attributes": {
"UNIFIER_LIMIT": 8,
"STREAM_CODEC" : {
- "com.datatorrent.common.codec.JsonStreamCodec" : {}
+
"com.datatorrent.stram.plan.logical.LogicalPlanConfigurationTest$TestStreamCodec"
: {}
}
--- End diff --
Yes, the test fails with the original JSON. So I changed the stream codec
class in JSON.
It does make the change backword incompatible due to an additional
validation. However, if attribute values are not serializable, the app
currently fails during deployment. we need to catch attribute serializability
in validate phase itself.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
