Github user ilganeli commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/130#discussion_r42711984
--- Diff:
engine/src/main/java/com/datatorrent/stram/engine/StreamingContainer.java ---
@@ -920,8 +927,8 @@ private void deployNodes(List<OperatorDeployInfo>
nodeList) throws IOException
}
private HashMap<String, ComponentContextPair<Stream, StreamContext>>
deployOutputStreams(
- List<OperatorDeployInfo> nodeList, HashMap<String, ArrayList<String>>
groupedInputStreams)
- throws Exception
+ List<OperatorDeployInfo> nodeList, HashMap<String,
ArrayList<String>> groupedInputStreams)
--- End diff --
@tweise @chandnisingh What would you want this to look like? Is it with
regards to ```throws Exception``` being on the new line? This seems to be an
IDE Settings issue, code style does not adjust it one way or the other. The
relevant setting seems to be ```throws keyword``` to ```wrap if long``` but it
makes no difference. I think from a style perspective both are valid.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---