Github user chandnisingh commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-core/pull/130#discussion_r42712717
  
    --- Diff: 
engine/src/main/java/com/datatorrent/stram/engine/StreamingContainer.java ---
    @@ -920,8 +927,8 @@ private void deployNodes(List<OperatorDeployInfo> 
nodeList) throws IOException
       }
     
       private HashMap<String, ComponentContextPair<Stream, StreamContext>> 
deployOutputStreams(
    -    List<OperatorDeployInfo> nodeList, HashMap<String, ArrayList<String>> 
groupedInputStreams)
    -    throws Exception
    +      List<OperatorDeployInfo> nodeList, HashMap<String, 
ArrayList<String>> groupedInputStreams)
    --- End diff --
    
    Isn't the change adding more spaces? continuation indentation looks like 
more than 2 spaces. I am using apex style for IntelliJ and that has 
continuation indentation set to 2. 
    
    The problem with apex style (for IntelliJ which is checked in) is that it 
aligns method parameters which I will fix.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to