As long as hooks to do it (with reasonable effort) in the derived class are present, let's punt on this.
This is an abstract class that does not need to solve all possibilities. Please add pointer to the example to the ticket and then let's wait for Priyanka to close it, if she agrees. On Thu, Nov 5, 2015 at 6:15 PM, Chandni Singh <[email protected]> wrote: > I am not sure. If this ticket warrants us to write an extension for S3 and > FtpFileSystem then I haven't added that and in that case it cannot be > closed. > > I provided an example but that is not ready to be merged because it needs > test and maybe more work. > > Also S3N may not have an AbstractFileSystem equivalent yet (wrt > FileContext) but FTPFileSystem and HAR do have. So providing extensions > for this in Malhar lib is a much bigger task (not a bug) which needs time. > > Chandni > > On Thu, Nov 5, 2015 at 6:06 PM, Thomas Weise <[email protected]> > wrote: > > > https://malhar.atlassian.net/browse/MLHR-1888 > > > > Is it resolved via 1886 or is there more work to do? > > > > > > On Thu, Nov 5, 2015 at 6:02 PM, Chandni Singh <[email protected]> > > wrote: > > > > > Tim and I have merged AbstractFileOutputOperator changes to > release-3.2. > > > > > > Thanks, > > > Chandni > > > > > > On Thu, Nov 5, 2015 at 2:27 PM, Chandni Singh <[email protected] > > > > > wrote: > > > > > > > Yes will do by today. > > > > On Nov 5, 2015 2:09 PM, "Thomas Weise" <[email protected]> > wrote: > > > > > > > >> We have currently 34 issues for this version, 4 of them remain to be > > > >> resolved (or moved out). > > > >> > > > >> https://malhar.atlassian.net/projects/MLHR/versions/11702 > > > >> > > > >> Chandni, as discussed we would like to include the > > > >> AbstractFileOutputOperator changes. > > > >> > > > >> On Wed, Nov 4, 2015 at 7:48 PM, Thomas Weise < > [email protected]> > > > >> wrote: > > > >> > > > >> > Everyone processing PRs please review the guidelines: > > > >> > > > > >> > http://apex.incubator.apache.org/contributing.html > > > >> > > > > >> > Until further notice, the committer merging the PR is responsible > to > > > set > > > >> > the fixVersion. > > > >> > > > > >> > > > > >> > On Wed, Nov 4, 2015 at 7:29 PM, Chandni Singh < > > > [email protected]> > > > >> > wrote: > > > >> > > > > >> >> MLHR-1886, MLHR-1889 can be a part of 3.2.0 as well. > > > >> >> > > > >> >> On Wed, Nov 4, 2015 at 7:26 PM, Thomas Weise < > > [email protected] > > > > > > > >> >> wrote: > > > >> >> > > > >> >> > There should be a large amount of issues: > > > >> >> > > > > >> >> > > > > >> >> > > > > >> >> > > > >> > > > > > > https://malhar.atlassian.net/issues/?jql=project%20%3D%20Malhar%20and%20fixVersion%20%3D%203.2.0%20or%20(fixVersion%20is%20EMPTY%20and%20resolution%20%3D%20Fixed) > > > >> >> > > > > >> >> > Looks like everything updated since September should be > included? > > > >> >> > > > > >> >> > > > > >> >> > > > > >> >> > On Wed, Nov 4, 2015 at 7:17 PM, Thomas Weise < > > > [email protected] > > > >> > > > > >> >> > wrote: > > > >> >> > > > > >> >> > > We want to prepare the 3.2.0 release for Malhar. > > > >> >> > > > > > >> >> > > I only see 2 issues showing up for this version: > > > >> >> > > > > > >> >> > > https://malhar.atlassian.net/projects/MLHR/versions/11702 > > > >> >> > > > > > >> >> > > I suspect many issue don't have the fixVersion set? Anyone > > wants > > > to > > > >> >> > > volunteer to review and fix this? > > > >> >> > > > > > >> >> > > Also, are there any other, open tickets you may know of that > > > >> should be > > > >> >> > > resolved for this release? > > > >> >> > > > > > >> >> > > Thanks, > > > >> >> > > Thomas > > > >> >> > > > > > >> >> > > > > > >> >> > > > > > >> >> > > > > > >> >> > > > > > >> >> > > > > >> >> > > > >> > > > > >> > > > > >> > > > > > > > > > >
