Github user PramodSSImmaneni commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/166#discussion_r44608737
--- Diff: engine/src/main/java/com/datatorrent/stram/engine/InputNode.java
---
@@ -69,24 +69,27 @@ public final void run()
long spinMillis = context.getValue(OperatorContext.SPIN_MILLIS);
final boolean handleIdleTime = operator instanceof IdleTimeHandler;
- boolean insideWindow = applicationWindowCount != 0;
+ boolean insideApplicationWindow = applicationWindowCount != 0;
boolean doCheckpoint = false;
+ boolean insideStreamingWindow = false;
try {
while (alive) {
Tuple t = controlTuples.sweep();
if (t == null) {
- if (insideWindow) {
+ if (insideApplicationWindow) {
--- End diff --
This should be insideStreamingWindow as well. For example handleIdleTime
should not be called between streaming window boundaries.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
