Github user chandnisingh commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-core/pull/166#discussion_r44999231
  
    --- Diff: engine/src/main/java/com/datatorrent/stram/engine/InputNode.java 
---
    @@ -145,7 +148,7 @@ else if (PROCESSING_MODE == 
ProcessingMode.EXACTLY_ONCE) {
     
                   ContainerStats.OperatorStats stats = new 
ContainerStats.OperatorStats();
                   reportStats(stats, currentWindowId);
    -              if(!insideWindow){
    +              if(!insideApplicationWindow){
    --- End diff --
    
    Metrics are collected at the end of application window. I think Tim has 
just changed the name of the variable and nothing else has changed. 
@PramodSSImmaneni please go through older discussions about why Metrics are 
collected at the end of application window. Also I have an improvement where it 
phase of metrics collections can be specified.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to