Github user vrozov commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/162#discussion_r44938812
--- Diff: engine/src/main/java/com/datatorrent/stram/engine/Reservoir.java
---
@@ -23,20 +23,26 @@
*
* @since 0.3.2
*/
-public interface Reservoir
+public interface Reservoir<T>
{
/**
* the count of elements in this SweepableReservoir.
*
* @return the count
*/
- public int size();
+ int size(final boolean dataTupleAware);
--- End diff --
@gauravgopi123 Other than for CircularBufferReservoir this parameter will
not be supported. Getting **exact** queue size is way too expensive, so
SpscArrayQueue gives an upper estimate on the queue size. Filtering out control
tuples is even more costly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
