Github user vrozov commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/162#discussion_r44970614
--- Diff:
engine/src/main/java/com/datatorrent/stram/stream/BufferServerSubscriber.java
---
@@ -242,6 +243,21 @@ public long getByteCount(boolean reset)
}
@Override
+ public int size(final boolean dataTupleAware)
+ {
+ int size = size();
+ if (dataTupleAware) {
--- End diff --
@gauravgopi123 I don't see how control tuples may significantly affect
queue size. Assuming any reasonable queue capacity there will be only few
control tuples in the queue compared to payload tuples and they should not make
much difference on backlog. Is there a test case that demonstrates significance
of excluding control tuples from the queue size?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
