Github user davidyan74 commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/171#discussion_r45103271
--- Diff:
common/src/main/java/com/datatorrent/common/util/PubSubWebSocketClient.java ---
@@ -376,7 +385,8 @@ public void unsubscribe(String topic) throws IOException
* @return subscribe num subscriber message.
* @throws IOException
*/
- public static <T> String constructSubscribeNumSubscribersMessage(String
topic, PubSubMessageCodec<T> codec) throws IOException
+ public static <T> String constructSubscribeNumSubscribersMessage(String
topic, PubSubMessageCodec<T> codec) throws
+ IOException
--- End diff --
Consistency and readability. You have other places that break before the
throws, and it is odd to break the line after the throws keyword. Imagine
something like:
{code}
public class SomeLongClassName extends
SomeOtherLongClassName implements
SomeLongInterfaceNameA
{code}
versus
{code}
public class SomeLongClassName
extends SomeOtherLongClassName
implements SomeLongInterfaceNameA
{code}
In the first case, SomeOtherLongClassName has nothing to do with the
implements keyword, and yet they are on the same line.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
