Github user chandnisingh commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/171#discussion_r45104998
--- Diff:
common/src/main/java/com/datatorrent/common/util/PubSubWebSocketClient.java ---
@@ -376,7 +385,8 @@ public void unsubscribe(String topic) throws IOException
* @return subscribe num subscriber message.
* @throws IOException
*/
- public static <T> String constructSubscribeNumSubscribersMessage(String
topic, PubSubMessageCodec<T> codec) throws IOException
+ public static <T> String constructSubscribeNumSubscribersMessage(String
topic, PubSubMessageCodec<T> codec) throws
+ IOException
--- End diff --
David I made those changes. However I have some comments here:
About your consistency point: places where throws may have a break before
because the method name and arguments maybe long enough.
And as I mentioned before if this task it to ensure readability of classes
that I am not the author of, then I shouldn't be making these changes.
Individual authors/owners should take them up.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
