Agree completely. Let's go with what check style can check and not worry about the rest.
Ram On Tue, Nov 17, 2015 at 6:02 PM, Timothy Farkas <[email protected]> wrote: > I think we already have a consistent style adopted and it is sufficient. > There are bigger priorities for the project than enforcing the optimal way > to format wrapped lines or other similar things. Frankly we should be > focusing on adding more unit tests, fixing bugs, and fixing features that > aren't fault tolerant (property setting). > > Just my opinion, > Tim > > On Tue, Nov 17, 2015 at 5:45 PM, Ganelin, Ilya <[email protected]> > wrote: > >> As long as there is consistency between code style and check style that's >> all that should matter. If consistency is impossible, then the check style >> shouldn't exist imo. >> >> >> >> Thank you, >> Ilya Ganelin >> >> >> >> -----Original Message----- >> From: Chandni Singh [[email protected]<mailto: >> [email protected]>] >> Sent: Tuesday, November 17, 2015 08:24 PM Eastern Standard Time >> To: [email protected] >> Subject: Extent of attention to code style in code reviews >> >> >> Since we are getting religious about code styles and concerns are being >> raised about wrapping lines in a better way to improve readability, I think >> this is one place we can learn from some other apache projects. >> >> https://flink.apache.org/contribute-code.html#code-style >> >> https://maven.apache.org/developers/conventions/code.html >> >> https://wiki.apache.org/cassandra/CodeStyle >> >> IMO none of these projects are enforcing style to the extent we have >> adopted. >> I think if we start focussing on style to this extent, that is, where to >> break a line while wrapping, then our review process will result in more >> frustration. I think this doesn't help the community to grow. >> >> Thanks, >> Chandni >> ________________________________________________________ >> >> The information contained in this e-mail is confidential and/or >> proprietary to Capital One and/or its affiliates and may only be used >> solely in performance of work or services for Capital One. The information >> transmitted herewith is intended only for use by the individual or entity >> to which it is addressed. If the reader of this message is not the intended >> recipient, you are hereby notified that any review, retransmission, >> dissemination, distribution, copying or other use of, or taking of any >> action in reliance upon this information is strictly prohibited. If you >> have received this communication in error, please contact the sender and >> delete the material from your computer. >>
