I love you Ted. On Nov 17, 2015 8:52 PM, "Ted Dunning" <[email protected]> wrote:
> Many groups go through a phase of excessive fascination on formatting and > they generally pull back a bit after that. > > Same thing that is happening here. > > Live and let live. Make it prettier and more readable as you can. Make > checkstyle catch what it can catch reliably and depend on human judgement > for the rest. > > Also, if some have better tools for reviewing and fixing these problems, > that's great because they can help make patches prettier. My own feeling > is that I should be willing to fix the patch rather than bitch about > formatting. Saves time and effort. > > > > On Wed, Nov 18, 2015 at 10:23 AM, Chandni Singh <[email protected]> > wrote: > > > Since we are getting religious about code styles and concerns are being > > raised about wrapping lines in a better way to improve readability, I > think > > this is one place we can learn from some other apache projects. > > > > https://flink.apache.org/contribute-code.html#code-style > > > > https://maven.apache.org/developers/conventions/code.html > > > > https://wiki.apache.org/cassandra/CodeStyle > > > > IMO none of these projects are enforcing style to the extent we have > > adopted. > > I think if we start focussing on style to this extent, that is, where to > > break a line while wrapping, then our review process will result in more > > frustration. I think this doesn't help the community to grow. > > > > Thanks, > > Chandni > > >
