What I suggested wasn't an exception (agreed that isn't manageable) but drop the line length enforcement.
Thomas On Wed, Nov 18, 2015 at 5:15 PM, Vlad Rozov <[email protected]> wrote: > Problem with exception is that it requires maintenance over time and I > believe there is no way to distinguish line length violation from another > violations in checkstyle count that aggregates all violations and fails the > build once total count exceeds allowed number of violations recorded in the > project pom.xml. > > I think we need volunteers from voters for "fix checkstyle issues in few > batches" to come forward and help Chandni. I will look into the > bufferserver violations. > > Thank you, > > Vlad > > > On 11/18/15 16:07, Pramod Immaneni wrote: > >> Can we enforce 120 in checkstyle and add exceptions as they arise. We >> already do that for legacy code. >> >> On Wed, Nov 18, 2015 at 3:55 PM, Thomas Weise <[email protected]> >> wrote: >> >> We can have a solution that is "comprehensive" without sweating over the >>> last 1%. I suppose Chandni brings this up now because she has been >>> wrestling with IDE and checkstyle settings for the past few months and >>> sees >>> the point of diminishing returns and things that are more important in >>> taking the project forward. >>> >>> I also agree that as result of attempting to fix long lines we should not >>> end up with wrapped lines that are really hard to read (to me, having a >>> few >>> long lines that exceed 120 characters is a non issue). Someone else made >>> the suggestion to make 120 a recommendation and not enforce it in >>> checkstyle >>> . >>> >>> Thanks, >>> Thomas >>> >>> >>> >>> On Tue, Nov 17, 2015 at 11:23 PM, Pramod Immaneni < >>> [email protected]> >>> wrote: >>> >>> The train has already left the station on this one. We have many things >>>> >>> in >>> >>>> place, checkstyle rules, IDE project settings in the git repo, coding >>>> >>> style >>> >>>> guidelines so why fret about the final 1%. Lets just go ahead and >>>> >>> implement >>> >>>> a code style for this scenario as well and end up doing a comprehensive >>>> job. >>>> >>>> Thanks >>>> >>>> On Tue, Nov 17, 2015 at 5:23 PM, Chandni Singh <[email protected] >>>> > >>>> wrote: >>>> >>>> Since we are getting religious about code styles and concerns are being >>>>> raised about wrapping lines in a better way to improve readability, I >>>>> >>>> think >>>> >>>>> this is one place we can learn from some other apache projects. >>>>> >>>>> https://flink.apache.org/contribute-code.html#code-style >>>>> >>>>> https://maven.apache.org/developers/conventions/code.html >>>>> >>>>> https://wiki.apache.org/cassandra/CodeStyle >>>>> >>>>> IMO none of these projects are enforcing style to the extent we have >>>>> adopted. >>>>> I think if we start focussing on style to this extent, that is, where >>>>> >>>> to >>> >>>> break a line while wrapping, then our review process will result in >>>>> >>>> more >>> >>>> frustration. I think this doesn't help the community to grow. >>>>> >>>>> Thanks, >>>>> Chandni >>>>> >>>>> >
