Github user davidyan74 commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-core/pull/148#discussion_r47022323
  
    --- Diff: 
engine/src/main/java/com/datatorrent/stram/webapp/StramWebServices.java ---
    @@ -527,6 +567,33 @@ public JSONObject 
getLogicalOperator(@PathParam("operatorName") String operatorN
       }
     
       @GET
    +  @Path(PATH_LOGICAL_PLAN_MODULES + "/{moduleName:.+}")
    +  @Produces(MediaType.APPLICATION_JSON)
    +  public JSONObject getLogicalModule(@PathParam("moduleName") String 
moduleName) throws Exception
    +  {
    +    ModuleMeta logicalModule = dagManager.getModuleMeta(moduleName);
    +    if (logicalModule == null) {
    +      throw new NotFoundException();
    +    }
    +    LogicalModuleInfo logicalModuleInfo = 
dagManager.getLogicalModuleInfo(logicalModule, false);
    +    return new 
JSONObject(objectMapper.writeValueAsString(logicalModuleInfo));
    +  }
    +
    +  @GET
    +  @Path(PATH_LOGICAL_PLAN_MODULES + "/{moduleName}/flatten")
    +  @Produces(MediaType.APPLICATION_JSON)
    --- End diff --
    
    looks like the flatten implementation is not done yet since it's the same 
as the non-flatten one.  but the /flatten here should probably not be part of 
the path.  I would make flatten a QueryParam.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to