Github user tushargosavi commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/148#discussion_r46971737
--- Diff:
engine/src/main/java/com/datatorrent/stram/plan/logical/LogicalPlanConfiguration.java
---
@@ -122,8 +121,8 @@
* This represents an element that can be referenced in a DT property.
*/
protected enum StramElement {
- APPLICATION("application"), GATEWAY("gateway"), TEMPLATE("template"),
OPERATOR("operator"),STREAM("stream"), PORT("port"),
INPUT_PORT("inputport"),OUTPUT_PORT("outputport"),
- ATTR("attr"),
PROP("prop"),CLASS("class"),PATH("path"),UNIFIER("unifier");
+ APPLICATION("application"), GATEWAY("gateway"), TEMPLATE("template"),
OPERATOR("operator"), STREAM("stream"), PORT("port"), INPUT_PORT("inputport"),
OUTPUT_PORT("outputport"),
+ ATTR("attr"), PROP("prop"), CLASS("class"), PATH("path"),
UNIFIER("unifier"), MODULE("module");
--- End diff --
Yes, I have done the changes which use the operator conf to populate
properties on the module. Also added check in addOperator and addModule to
disallow same names.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
