Github user tushargosavi commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-core/pull/148#discussion_r47198502
  
    --- Diff: 
engine/src/main/java/com/datatorrent/stram/webapp/StramWebServices.java ---
    @@ -511,6 +532,16 @@ public JSONObject getLogicalOperators() throws 
Exception
         nodeList.operators = dagManager.getLogicalOperatorInfoList();
         return new JSONObject(objectMapper.writeValueAsString(nodeList));
       }
    +  
    +  @GET
    +  @Path(PATH_LOGICAL_PLAN_MODULES)
    +  @Produces(MediaType.APPLICATION_JSON)
    +  public JSONObject getLogicalModules(@QueryParam("flatten") String 
flatten) throws Exception
    --- End diff --
    
    tried it, this does not works too. 
    
    ```java
      public JSONObject getLogicalModules(@QueryParam("flatten") Boolean 
flatten) throws Exception
      {
        LogicalModulesInfo nodeList = new LogicalModulesInfo();
        nodeList.modules = 
dagManager.getLogicalModuleInfoList(BooleanUtils.isTrue(flatten));
        return new JSONObject(objectMapper.writeValueAsString(nodeList));
      }
    ```
    
    Tried issuing following requests
    ```
    /modules?flatten=true
    /modules?flatten=True
    /module?flatten=false
    /module?flatten
    ```
    In all the cases value of flatten was false.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to