Github user tweise commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-core/pull/148#discussion_r47200211
  
    --- Diff: 
engine/src/main/java/com/datatorrent/stram/plan/logical/LogicalPlanConfiguration.java
 ---
    @@ -2153,17 +2172,17 @@ public static Properties readProperties(String 
filePath) throws IOException
       /**
        * Get the configuration opProps for the given operator.
        * These can be operator specific settings or settings from matching 
templates.
    -   * @param ow
    +   * @param pa
        * @param opConfs
        * @param appName
        */
    -  private Map<String, String> getProperties(OperatorMeta ow, 
List<OperatorConf> opConfs, String appName)
    +  public Map<String, String> getProperties(PropertyArgs pa, 
List<OperatorConf> opConfs, String appName)
    --- End diff --
    
    Why was this made public?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to