Github user tweise commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/148#discussion_r47273568
--- Diff:
engine/src/main/java/com/datatorrent/stram/plan/logical/LogicalPlanConfiguration.java
---
@@ -2092,6 +2068,35 @@ public void populateDAG(LogicalPlan dag)
}
+ private void populateOperators(AppConf appConf, LogicalPlan dag,
Map<OperatorConf, Operator> nodeMap)
--- End diff --
Thanks, there is no rule that says a method can only have 100 lines. If
there is a good case for refactor, then do it as separate change, don't mix it
with an already giant and difficult to review pull request.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
