Github user tushargosavi commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-core/pull/148#discussion_r47203259
  
    --- Diff: 
engine/src/main/java/com/datatorrent/stram/plan/logical/LogicalPlanConfiguration.java
 ---
    @@ -2092,6 +2068,35 @@ public void populateDAG(LogicalPlan dag)
     
       }
     
    +  private void populateOperators(AppConf appConf, LogicalPlan dag, 
Map<OperatorConf, Operator> nodeMap)
    --- End diff --
    
    Original function (populateDAG) was long (> 100 lines) , while adding 
processing for modules it will get even bigger, hence moved the code around.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to