Github user vrozov commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-core/pull/208#discussion_r51064718
  
    --- Diff: engine/src/main/java/com/datatorrent/stram/StramLocalCluster.java 
---
    @@ -318,6 +333,21 @@ public StramLocalCluster(LogicalPlan dag) throws 
IOException, ClassNotFoundExcep
         }
       }
     
    +  private void addExtraJarsToClasspath(Set<String> jars)
    +      throws InvocationTargetException, IllegalAccessException, 
MalformedURLException, NoSuchMethodException
    +  {
    +    List<URL> jarUrls = new LinkedList<>();
    +    for (String jarPath : jars) {
    +      File file = new File(jarPath);
    +      URL url = file.toURI().toURL();
    +      jarUrls.add(url);
    +    }
    +
    +    ClassLoader prevCl = Thread.currentThread().getContextClassLoader();
    +    ClassLoader urlCl = URLClassLoader.newInstance(jarUrls.toArray(new 
URL[jarUrls.size()]), prevCl);
    +    Thread.currentThread().setContextClassLoader(urlCl);
    --- End diff --
    
    @tweise Is it expected that StramAppLauncher.runLocal() exposes different 
behavior compared to LocalMode.runApp()? I would expect 
StramAppLaunchar.runLocal to use LocalMode.runApp() so functionality is the 
same when application is launched in application test and using dtcli local 
mode.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to