Github user vrozov commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/208#discussion_r50869794
--- Diff: engine/src/main/java/com/datatorrent/stram/StramLocalCluster.java
---
@@ -318,6 +333,21 @@ public StramLocalCluster(LogicalPlan dag) throws
IOException, ClassNotFoundExcep
}
}
+ private void addExtraJarsToClasspath(Set<String> jars)
+ throws InvocationTargetException, IllegalAccessException,
MalformedURLException, NoSuchMethodException
+ {
+ List<URL> jarUrls = new LinkedList<>();
+ for (String jarPath : jars) {
+ File file = new File(jarPath);
+ URL url = file.toURI().toURL();
+ jarUrls.add(url);
+ }
+
+ ClassLoader prevCl = Thread.currentThread().getContextClassLoader();
+ ClassLoader urlCl = URLClassLoader.newInstance(jarUrls.toArray(new
URL[jarUrls.size()]), prevCl);
+ Thread.currentThread().setContextClassLoader(urlCl);
--- End diff --
Please provide unit test(s) that exercise adding custom jars to classpath
and loads custom classes using both Class.forName() and context ClassLoader. As
long as context ClassLoader is used to load all custom classes it should work,
but I don't see how it will for with the current ClassLoader if operators or
modules use Class.forName().
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
